issue 438-tom addressed
authorPaolo Missier <pmissier@acm.org>
Tue, 10 Jul 2012 22:21:20 +0100
changeset 3908 2548f0ada036
parent 3907 bed0a0977e98
child 3910 def852e760e9
issue 438-tom addressed
model/comments/issue-438-tom.txt
model/prov-n.html
--- a/model/comments/issue-438-tom.txt	Tue Jul 10 16:25:59 2012 -0400
+++ b/model/comments/issue-438-tom.txt	Tue Jul 10 22:21:20 2012 +0100
@@ -16,12 +16,18 @@
    > generation and usage identifiers g2 and u1: Should be "In the
    > following expressions, the optional activity a is specified along with
    > the generation and usage identifiers g2 and u1:"
+
+example 2 has changed? issue no longer applies
+
    > 
    > - 2.2 EBNF Grammar
    > 
    > Each expression non-terminal expression, i.e., entityExpression,
    >  activityExpression etc., This sentence is a bit weird. Should the
    >  first "expression" be omitted?
+
+already fixed 
+
    > 
    > - 2.5 Comments
    > typo: "cooments" (is fixed in latest editors draft I think)
@@ -41,6 +47,9 @@
     > This is a more general issue than just in this section. I would
    >       be consistent here and add the "Note:" everywhere where this
    >       type of comment is made.
+
+fixed
+
    > 
    > Also, it seems that these notes do not always make sense.  For
    > example, in 3.1.4, it says that at least one of id, entity, time, and
@@ -51,10 +60,16 @@
    > wasStartedBy(e2, -, -, -) and wasStartedBy(-; e2, -, -, -) are
    > invalid. However, a starter or a trigger is present. Did you mean: at
    > least one of id, activity, time, and attributes must be present.?
+
+no, I think this is fine [PM]
+
    > 
    > The same happens with 3.1.7 End.  3.1.8 Invalidation has the correct
    > remark: "at least one of id, activity, time, and attributes must be
    > present."  (but I would add the "Note:" here as well)
+
+again, they look ok to me [PM]
+
    > 
    > 
    > - 3.3.5 Influence Here id is the optional influence identifier, e2 is
@@ -67,6 +82,9 @@
    > actually a lighter relation than that I think.  Just rephrasing this
    > to something like "e1 is the identifier for an ancestor entity that e2
    > was influenced by" solves this.
+
+fixed
+
    > 
    > From here on everything looked fine to me :)
    > 
--- a/model/prov-n.html	Tue Jul 10 16:25:59 2012 -0400
+++ b/model/prov-n.html	Tue Jul 10 22:21:20 2012 +0100
@@ -1032,7 +1032,7 @@
 </div>
 
 
-<p>Even though the production <code class="content"><a class="grammarRef" href="#prod-usageExpression">usageExpression</a></code> allows for expressions <span class="name">used(a2, -, -)</span>  and <span class="name">used(-; a2, -, -)</span>, these expressions are not valid in PROV-N, since at least one  of <a href="http://www.w3.org/TR/prov-dm/#usage.id"><span class='attribute'>id</span></a>, <a href="http://www.w3.org/TR/prov-dm/#usage.entity"><span class='attribute'>entity</span></a>, <a href="http://www.w3.org/TR/prov-dm/#usage.time"><span class='attribute'>time</span></a>, and  <a href="http://www.w3.org/TR/prov-dm/#usage.attributes"><span class='attribute'>attributes</span></a> MUST be present.</p>
+<p><strong>Note:</strong> Even though the production <code class="content"><a class="grammarRef" href="#prod-usageExpression">usageExpression</a></code> allows for expressions <span class="name">used(a2, -, -)</span>  and <span class="name">used(-; a2, -, -)</span>, these expressions are not valid in PROV-N, since at least one  of <a href="http://www.w3.org/TR/prov-dm/#usage.id"><span class='attribute'>id</span></a>, <a href="http://www.w3.org/TR/prov-dm/#usage.entity"><span class='attribute'>entity</span></a>, <a href="http://www.w3.org/TR/prov-dm/#usage.time"><span class='attribute'>time</span></a>, and  <a href="http://www.w3.org/TR/prov-dm/#usage.attributes"><span class='attribute'>attributes</span></a> MUST be present.</p>
 
 
 
@@ -1280,7 +1280,7 @@
 </pre>
 </div>
 
-<p>Even though the production  <code class="content"><a class="grammarRef" href="#prod-invalidationExpression">invalidationExpression</a></code> allows for expressions <span class="name">wasInvalidatedBy(e2, -, -)</span>  and <span class="name">wasInvalidatedBy(-; e2, -, -)</span>, these expressions are not valid in PROV-N, since 
+<p><strong>Note:</strong> Even though the production  <code class="content"><a class="grammarRef" href="#prod-invalidationExpression">invalidationExpression</a></code> allows for expressions <span class="name">wasInvalidatedBy(e2, -, -)</span>  and <span class="name">wasInvalidatedBy(-; e2, -, -)</span>, these expressions are not valid in PROV-N, since 
 since at least one  of <a href="http://www.w3.org/TR/prov-dm/#invalidation.id"><span class='attribute'>id</span></a>, <a href="http://www.w3.org/TR/prov-dm/#invalidation.activity"><span class='attribute'>activity</span></a>, <a href="http://www.w3.org/TR/prov-dm/#invalidation.time"><span class='attribute'>time</span></a>, and  <a href="http://www.w3.org/TR/prov-dm/#invalidation.attributes"><span class='attribute'>attributes</span></a> MUST be present.</p>
 
 
@@ -1767,7 +1767,7 @@
 <p>  Here
     <span class="name">id</span> is the optional influence identifier,
   <span class="name">e2</span> is an entity identifier,
-  <span class="name">e1</span> is the identifier for an ancestor entity that   <span class="name">e2</span> depends on,
+  <span class="name">e1</span> is the identifier for an ancestor entity that   <span class="name">e2</span> is influenced by,
   and <span class="name">[ex:param="a"]</span> is the optional set of attributes. </p>
 The remaining examples show cases where some of the optionals are omitted.