Add some tests, adjust some XXXs
authorAryeh Gregor <AryehGregor+gitcommit@gmail.com>
Sun, 29 May 2011 16:11:32 -0600
changeset 191 924539fdd89d
parent 190 ba77f9116ec3
child 192 b23b2abea8cb
Add some tests, adjust some XXXs
autoimplementation.html
editcommands.html
linebreaktest.html
source.html
--- a/autoimplementation.html	Sun May 29 15:48:24 2011 -0600
+++ b/autoimplementation.html	Sun May 29 16:11:32 2011 -0600
@@ -1173,10 +1173,11 @@
 
 		'<h1>foo[bar</h1><p>baz]quz</p>',
 		'<p>foo[bar</p><h1>baz]quz</h1>',
-		'<p>foo</p>{}',
-		'{}<p>foo</p>',
-		'<p>foo</p>{}<h1>bar</h1>',
-		'<h1>foo</h1>{}<p>bar</p>',
+		'<p>foo</p>{}<br>',
+		'{}<br><p>foo</p>',
+		'<p>foo</p>{}<br><h1>bar</h1>',
+		'<h1>foo</h1>{}<br><p>bar</p>',
+		'<h1>foo</h1>{}<br><h2>bar</h2>',
 		'<p>foo</p><h1>[bar]</h1><p>baz</p>',
 		'<p>foo</p>{<h1>bar</h1>}<p>baz</p>',
 	],
--- a/editcommands.html	Sun May 29 15:48:24 2011 -0600
+++ b/editcommands.html	Sun May 29 16:11:32 2011 -0600
@@ -786,6 +786,10 @@
 
 <p>To <dfn id=delete-the-selection>delete the selection</dfn>:
 
+<p class=XXX>This might blow up non-editable stuff.  It also might leave a
+block element empty, when we really need to add a <code class=external data-anolis-spec=html title="the br element"><a href=http://www.whatwg.org/html/#the-br-element>br</a></code> <a class=external data-anolis-spec=domcore href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-tree-child title=concept-tree-child>child</a> no matter
+what so it doesn't collapse.
+
 <ol>
   <li>Let <var title="">range</var> be the <a href=#active-range>active range</a>.
 
@@ -901,8 +905,6 @@
 
   <li>Call <code class=external data-anolis-spec=domrange title=dom-Range-deleteContents><a href=http://html5.org/specs/dom-range.html#dom-range-deletecontents>deleteContents()</a></code> on <var title="">range</var>.
 
-  <p class=XXX>This might blow up non-editable stuff.
-
   <li>If <var title="">start block</var> or its <a class=external data-anolis-spec=domcore href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-tree-parent title=concept-tree-parent>parent</a> is null, or <var title="">end
   block</var> or its <a class=external data-anolis-spec=domcore href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-tree-parent title=concept-tree-parent>parent</a> is null, or <var title="">start block</var> is an
   <a class=external data-anolis-spec=domcore href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-tree-ancestor title=concept-tree-ancestor>ancestor</a> or <a class=external data-anolis-spec=domcore href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-tree-descendant title=concept-tree-descendant>descendant</a> of <var title="">end block</var>, abort these steps.
@@ -4172,8 +4174,6 @@
 
 <p><a href=#action>Action</a>:
 
-<p class=XXX>Under construction, probably makes no sense.
-
 <ol>
   <li><a href=#delete-the-selection>Delete the selection</a>.
 
@@ -4200,6 +4200,8 @@
   <li>If <var title="">node</var> has an <code class=external data-anolis-spec=domcore><a href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#element>Element</a></code> <a class=external data-anolis-spec=domcore href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-tree-child title=concept-tree-child>child</a> of <a class=external data-anolis-spec=domrange href=http://html5.org/specs/dom-range.html#concept-indexof title=concept-indexof>index</a>
   <var title="">offset</var>, let <var title="">container</var> equal that <a class=external data-anolis-spec=domcore href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-tree-child title=concept-tree-child>child</a>.
 
+  <p class=XXX>This doesn't seem to make sense.  Investigate.
+
   <li>Otherwise, if <var title="">node</var> has an <code class=external data-anolis-spec=domcore><a href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#element>Element</a></code> <a class=external data-anolis-spec=domcore href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-tree-child title=concept-tree-child>child</a> of <a class=external data-anolis-spec=domrange href=http://html5.org/specs/dom-range.html#concept-indexof title=concept-indexof>index</a>
   <var title="">offset</var> minus one, let <var title="">container</var> equal that <a class=external data-anolis-spec=domcore href=http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-tree-child title=concept-tree-child>child</a>.
 
--- a/linebreaktest.html	Sun May 29 15:48:24 2011 -0600
+++ b/linebreaktest.html	Sun May 29 16:11:32 2011 -0600
@@ -149,10 +149,11 @@
 
 	'<h1>foo[bar</h1><p>baz]quz</p>',
 	'<p>foo[bar</p><h1>baz]quz</h1>',
-	'<p>foo</p>{}',
-	'{}<p>foo</p>',
-	'<p>foo</p>{}<h1>bar</h1>',
-	'<h1>foo</h1>{}<p>bar</p>',
+	'<p>foo</p>{}<br>',
+	'{}<br><p>foo</p>',
+	'<p>foo</p>{}<br><h1>bar</h1>',
+	'<h1>foo</h1>{}<br><p>bar</p>',
+	'<h1>foo</h1>{}<br><h2>bar</h2>',
 	'<p>foo</p><h1>[bar]</h1><p>baz</p>',
 	'<p>foo</p>{<h1>bar</h1>}<p>baz</p>',
 ];
--- a/source.html	Sun May 29 15:48:24 2011 -0600
+++ b/source.html	Sun May 29 16:11:32 2011 -0600
@@ -750,6 +750,10 @@
 
 <p>To <dfn>delete the selection</dfn>:
 
+<p class=XXX>This might blow up non-editable stuff.  It also might leave a
+block element empty, when we really need to add a [[br]] [[child]] no matter
+what so it doesn't collapse.
+
 <ol>
   <li>Let <var>range</var> be the <span>active range</span>.
 
@@ -868,8 +872,6 @@
   <li>Call <code data-anolis-spec=domrange
   title=dom-Range-deleteContents>deleteContents()</code> on <var>range</var>.
 
-  <p class=XXX>This might blow up non-editable stuff.
-
   <li>If <var>start block</var> or its [[parent]] is null, or <var>end
   block</var> or its [[parent]] is null, or <var>start block</var> is an
   [[ancestor]] or [[descendant]] of <var>end block</var>, abort these steps.
@@ -4205,8 +4207,6 @@
 
 <p><span>Action</span>:
 
-<p class=XXX>Under construction, probably makes no sense.
-
 <ol>
   <li><span>Delete the selection</span>.
 
@@ -4235,6 +4235,8 @@
   <li>If <var>node</var> has an [[element]] [[child]] of [[index]]
   <var>offset</var>, let <var>container</var> equal that [[child]].
 
+  <p class=XXX>This doesn't seem to make sense.  Investigate.
+
   <li>Otherwise, if <var>node</var> has an [[element]] [[child]] of [[index]]
   <var>offset</var> minus one, let <var>container</var> equal that [[child]].