> > > Question for reviewers: Can the document be published as Last Call working draft? > > > > Yes, modulo comments below. > > 0. As with prov-dm, I'm unsure whether additional authors need to be > listed. I contributed to the discussion of how to avoid ambiguity > (identifiers and optional arguments), perhaps others currently listed > as authors of prov-dm also contributed and should be acknowledged. I > didn't actually write anything so wouldn't fight to be added, but I > also contributed to PROV-O without directly writing the text. > > 1. S1.2. "This document *is* structured as follows" > fixed > 2. Example 2: The sentence in the example has no verb. fixed > > 3. Example 8: It looks strange to me that the three statements all > use ex:a10 instead of different ids. (Also, why a10? Maybe this used > to be example 10) a10 -> a1 > > 4. S2.5: "cooments" sp. fixed > > 5. S3.3.4: "wasAssociatiedWith" sp. fixed > > 6. S3.3.5: Replace the keyword "influence" with "wasInfluencedBy" > everywhere. Grammar and text updated. > > 7. Example 25, first statement, the first comma should be semicolon fixed > > 8. Many relations (wasStartedBy, etc.) have a "Note" saying that at > least one of the optional parameters must be present. Please > summarize these rules somewhere since it seems (to me) easy to miss > one. Alternatively, they could be expressed by adding grammar rules > (I think this was suggested and discarded before, it's probably not > very maintainable.) TODO > > 9. S3.4.1. There are no examples exercising the option to declare > namespaces in this section. Please add one, or link to the later > section on namespace declarations that does have these examples. Added example 41 > > 10. S3.6. Cf. my suggestion for PROV-DM to just have a single binary > relation memberOf(element, collection), without the id, attributes or > completeness flag. This section would also have to change if this > suggestion is adopted. Resolution was to move out dictionaries and keep collections unchanged. > > 11. In productions 59-63, it seems that some nonterminals are > references to SPARQL nonterminals, while others have the same name as > SPARQL nonterminals but have been redefined. Is it possible to > include all of these to make the PROV-N grammar self-contained? (It > also might help to give new names to the SPARQL nonterminals that are > being redefined.) I was keen to reuse existing productions to avoid having to justify them. The only one not redefined is PN_LOCAL, but I thought it was OK to keep the name. Thoughts? Such names can still be changed after LC. > > 12. The hyperlink on PN_PREFIX goes to the wrong place in SPARQL. Link updated. > > 13. It seems that a string consisting of a single '-' can be parsed > as PN_CHARS_OTHERS and hens also as a PN_LOCAL. This makes rules > 38-42 ambiguous. On the other hand, lots of URIs use '-'. Suggested > fix: Allow '-' only if it is not the first or last character (could be > handled similar to '.'). '-' can be parsed as PN_CHARS but not as PN_CHARS_U nor PN_CHARS_OTHERS. So, '-' is not allow a valid PN_LOCAL Note '~' is valid PN_CHARS_OTHERS, maybe it's the origin of the confusion? > > 14. S4. Suggest pointing out that bundles cannot be nested (because > bundles aren't expressions) This was added. > > 15. ProvRDF and ProvXML wiki page citations: I don't see why we need > these, and if we do, I don't think the authorship is correct - I am > definitely not the only contributor to ProvRDF, and unlikely to do any > more work on ProvXML (which should eventually be a note). Can you provide authors for ProvRDF? For now you did this provxml page, so it's appropriate to cite you > > 16. PROV-SEM will eventually become a note if published, but I'm not > sure we need to explicitly reference it here as a wiki page. I guess > this can change later as appropriate. It's OK, it's informative. > > --James > -- The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. >